Attention is currently required from: laforge, pespin, fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31417
)
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
......................................................................
Patch Set 6:
(2 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/dd2816c8_596bda49
PS5, Line 1260: if (OSMO_UNLIKELY((resp_msg->len != GSM_HR_BYTES + 1)
this alignment looks weird, given that the next line
sees to be inside the OSMO_UNLIKELY macro.
Yes, the alignment is indeed wrong.
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/6b715061_51845000
PS5, Line 1267: && bts_internal_flag_get(lchan->ts->trx->bts,
BTS_INTERNAL_FLAG_SPEECH_H_V1_RTP_TS101318))) {
agreeing with pespin. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/31417
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e
Gerrit-Change-Number: 31417
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 May 2023 11:16:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment