Change in osmo-bsc[master]: struct gsm_encr: store alg_id in human-readable format

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27509 ) Change subject: struct gsm_encr: store alg_id in human-readable format ...................................................................... Patch Set 3: (6 comments) This change is ready for review. Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/ec43a57c_06cadbdd PS2, Line 30: ciph_mod_set = (lchan->encr.alg_id << 1) | 1; Indeed, thanks! Fixed in the next patchset revision. File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/fa25f947_37a5464b PS2, Line 613: uint8_t alg_id; Agreed, done. File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/c95648f8_54016850 PS2, Line 163: switch (*out++) { Done https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/dade52f4_2485fa17 PS2, Line 663: if (lchan->encr.alg_id > 0) { Done File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/f9bf4d9c_85b2a568 PS2, Line 596: _id Done File src/osmo-bsc/gsm_08_08.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/38a76e39_eebd4e6a PS2, Line 88: chosen_encr Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ieb50c9a352cfa5481aebac2379e0a461663543ec Gerrit-Change-Number: 27509 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 15 Mar 2022 15:45:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-MessageType: comment