Attention is currently required from: Hoernchen.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/35549?usp=email )
Change subject: test: adjust for libosmocore loglevel cache
......................................................................
Patch Set 1:
(1 comment)
File tests/nanobts_omlattr/nanobts_omlattr_test.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/35549/comment/8cdc7a35_61d6c709
PS1, Line 275: talloc_total_blocks(ctx) == 6
Well, I am simply suggesting a more fundamental fix, eliminating the need to adjust this
count again next time somebody changes logging:
I would suggest to call `log_fini()` before checking
the talloc report.
If you do so, then there will be only one block alone - the root ctx.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/35549?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If52bcb522d41918db9e0755ead58abdcb8f0209b
Gerrit-Change-Number: 35549
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Jan 2024 17:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment