Attention is currently required from: laforge.
dexter has posted comments on this change by laforge. (
https://gerrit.osmocom.org/c/python/pyosmocom/+/38187?usp=email )
Change subject: Allow caller to pass total_len in context of
osmocom.construct.build_construct
......................................................................
Patch Set 1: Code-Review+2 Verified+1
(2 comments)
Patchset:
PS1:
I have tested it now, seems to work fine.
File src/osmocom/construct.py:
https://gerrit.osmocom.org/c/python/pyosmocom/+/38187/comment/e5872387_a4ca…
:
PS1, Line 496: return c.build(decoded_data, **context)
This is probably the safest way in terms of API
stability. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/python/pyosmocom/+/38187?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I7c4eab60274bcb0dd95e7bc21867a37ad70e4fc0
Gerrit-Change-Number: 38187
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 17 Sep 2024 13:37:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>