[S] Change in osmo-pcu[master]: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks

Attention is currently required from: jolly, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32694 ) Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/9a067650_7591d79e PS1, Line 28: OS##5927 only one `#` please File src/gprs_rlcmac.c: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/31d2fd3f_cec4e5b6 PS1, Line 20: #include <osmocom/core/bitvec.h> why adding this header? https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/0fdfd5c8_7480f857 PS1, Line 49: mi->tmsi You're saying TLLI, but actually passing a TMSI -- this is not always the same thing. Also, `struct osmo_mobile_identity` is not guaranteed to contain TMSI here, it may contain IMSI or even IMEI I think. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 Gerrit-Change-Number: 32694 Gerrit-PatchSet: 1 Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Comment-Date: Sun, 14 May 2023 11:33:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment