Attention is currently required from: jolly, pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32694 )
Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/9a067650_7591d79e PS1, Line 28: OS##5927 only one `#` please
File src/gprs_rlcmac.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/31d2fd3f_cec4e5b6 PS1, Line 20: #include <osmocom/core/bitvec.h> why adding this header?
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/0fdfd5c8_7480f857 PS1, Line 49: mi->tmsi You're saying TLLI, but actually passing a TMSI -- this is not always the same thing. Also, `struct osmo_mobile_identity` is not guaranteed to contain TMSI here, it may contain IMSI or even IMEI I think.