Attention is currently required from: jolly, pespin, dexter.

Patch set 1:Code-Review -1

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 28: OS##5927

    only one `#` please

• File src/gprs_rlcmac.c:

  • Patch Set #1, Line 20: #include <osmocom/core/bitvec.h>

    why adding this header?

  • Patch Set #1, Line 49: mi->tmsi

    You're saying TLLI, but actually passing a TMSI -- this is not always the same thing. Also, `struct osmo_mobile_identity` is not guaranteed to contain TMSI here, it may contain IMSI or even IMEI I think.

To view, visit change 32694. To unsubscribe, or for help writing mail filters, visit settings.