19 Jan
2024
19 Jan
'24
2:38 p.m.
Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email )
Change subject: gitignore: add libhnbgw.la, hnbgw_vty_reference.xml ......................................................................
Patch Set 1:
(2 comments)
File .gitignore:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/62a120df_a0d6fe3f PS1, Line 49: src/osmo-hnbgw/libhnbgw.la You should instead add "*.la" in line 5.
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/e6b23882_3b195aa9 PS1, Line 71: doc/manuals/vty/hnbgw_vty_reference.xml Why are you adding this here? I think it's totally sane having this outside of gitignore. Check other repos like osmo-bsc.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1
Gerrit-Change-Number: 35619
Gerrit-PatchSet: 1
Gerrit-Owner: osmith osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 19 Jan 2024 13:38:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment