Attention is currently required from: jolly, dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32930 )
Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File include/osmocom/gsm/protocol/gsm_44_068.h:
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/3c4e6c41_f65af601
PS1, Line 9: (C) 2023 by Andreas Eversberg <jolly(a)eversberg.eu>
copyright is with sysmocom for code written by employees during work time. Check other
files where you have templates like "(C) sysmocom - s.f.m.c. GmbH, Author:
...."
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/1b482139_0976e0c2
PS1, Line 19: enum gcc_iei {
in general we try to avoid clobbering the global namespace with symbols or type names
without an osmo_* prefix for new code, see
https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards#…
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32930
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3554cea47e714c8fca18c3e9c0e6e80695915a90
Gerrit-Change-Number: 32930
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 23 May 2023 15:12:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment