Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40291?usp=email )
Change subject: sccp: SCOC -> SCRC: Delay called addr lookup until needed [2/3]
......................................................................
Patch Set 2: -Code-Review
(1 comment)
File src/sccp_scrc.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40291/comment/05a4f821_2d391…
:
PS1, Line 464: if (0) {
I actually prefer keeping it this way without touching
it, it denotes better we really have a whole […]
Could you then make the TODO
searchable by fixing the typo?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40291?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I1dda9b9288f3f34dfad6064e3f9fff6dcd6abbd7
Gerrit-Change-Number: 40291
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 May 2025 14:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>