Attention is currently required from: laforge, pespin.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28939 )
Change subject: tests: Run smscb/gsm0341_test during make check
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File tests/smscb/gsm0341_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/28939/comment/75d72641_2231464f
PS3, Line 37: //srand(time(NULL));
Remove the comment
https://gerrit.osmocom.org/c/libosmocore/+/28939/comment/5142f5cd_0c8431a0
PS3, Line 40: //cbmsg = gsm0341_build_msg(NULL, 0, rand(), 0, msg_id, 0x0f, 1, 1,
payload, payload_octets);
Does this need to be here?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28939
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icd4feced06afb749de994195c6b338df006749ad
Gerrit-Change-Number: 28939
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Aug 2022 14:14:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment