Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40290?usp=email )
Change subject: sccp: Improve spec references in code documentation
......................................................................
Patch Set 1:
(1 comment)
File src/sccp_scrc.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40290/comment/5db70781_54792…
:
PS1, Line 245: /* "Figure C.1/Q.714 - SCCP routing control procedures (SCRC) (sheet 5
of 12)"
Not sure if that's too pedantic, but could you change it to
```
/* ITU Q.714: Figure X.Y
```
(and below as well)?
It wasn't clear to me what the spec was so I scrolled all the way to the top of the
file to find it's Q.714.
That's also how I found an existing comment (in the proposed format) in line 65.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40290?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ie43f9472322e7b6ed3ce8fc91408c074ddb98378
Gerrit-Change-Number: 40290
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 May 2025 13:33:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No