Attention is currently required from: daniel.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email )
Change subject: gtp: add support for SGSN Context Req/Resp/Ack ......................................................................
Patch Set 8:
(6 comments)
File include/osmocom/gtp/gsn.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/6aa1f986_fc34ba55?usp... : PS8, Line 116: int (*cb_sgsn_context_request_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/6788ca1a_4c4d8e9a?usp... : PS8, Line 117: int (*cb_sgsn_context_response_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/e3e9b6d2_4d0bf7a6?usp... : PS8, Line 118: int (*cb_sgsn_context_ack_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/ade01855_eca7b938?usp... : PS8, Line 169: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/0c259011_05ef0591?usp... : PS8, Line 172: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/9fde7bb9_f68f19ef?usp... : PS8, Line 175: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments