Attention is currently required from: daniel.
Jenkins Builder has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email )
Change subject: gtp: add support for SGSN Context Req/Resp/Ack
......................................................................
Patch Set 8:
(6 comments)
File include/osmocom/gtp/gsn.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957):
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/6aa1f986_fc34ba55?us… :
PS8, Line 116: int (*cb_sgsn_context_request_ind) (struct gsn_t *gsn, struct sockaddr_in
*peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957):
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/6788ca1a_4c4d8e9a?us… :
PS8, Line 117: int (*cb_sgsn_context_response_ind) (struct gsn_t *gsn, struct sockaddr_in
*peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957):
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/e3e9b6d2_4d0bf7a6?us… :
PS8, Line 118: int (*cb_sgsn_context_ack_ind) (struct gsn_t *gsn, struct sockaddr_in
*peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957):
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/ade01855_eca7b938?us… :
PS8, Line 169: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t
local_ref, union gtpie_member **ie, unsigned int ie_size));
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957):
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/0c259011_05ef0591?us… :
PS8, Line 172: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t
local_ref, union gtpie_member **ie, unsigned int ie_size));
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20957):
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/9fde7bb9_f68f19ef?us… :
PS8, Line 175: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t
local_ref, union gtpie_member **ie, unsigned int ie_size));
Unnecessary space before function pointer arguments
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0
Gerrit-Change-Number: 38938
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Jan 2025 16:34:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No