Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email )
Change subject: mobile: init/deinit GAPK I/O based on CC transaction events ......................................................................
Patch Set 3:
(1 comment)
File src/host/layer23/include/osmocom/bb/mobile/tch.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/35579/comment/2b142e8c_2dce6080 PS3, Line 8: bool voice_or_data; /* voice (true) or data (false) */
"totally misleading" sounds totally subjective to me :P But ok.
it is totally misleading because when reading code "if (voice_or_data)" it clearly seems to (wrongly) indicate that it's either voice or data, not voice.