Attention is currently required from: lynxis lazus.
neels has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email )
Change subject: vlr: extend the subscriber invalidate callback with reasons
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/9db0eaec_dddc7a71?usp… :
PS5, Line 10: There are multiple cases when this happens:
(maybe a good idea too add this very useful list in the api doc comment for the callback)
File include/osmocom/vlr/vlr.h:
https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/0643a0a8_eb8d2369?usp… :
PS5, Line 253:
(maybe good to describe the meaning of the cancel_by_update argument)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3
Gerrit-Change-Number: 38488
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 15 Jan 2025 13:34:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes