Attention is currently required from: fixeria, jolly.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440?usp=email )
Change subject: 5gc: Implement NAS integrity check of DL messages ......................................................................
Patch Set 6:
(5 comments)
File 5gc/C5G_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/05bc2722_e209c... : PS6, Line 44: NG_NAS_Osmo_Templates
duplicate, check above
Acknowledged
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/5f99b440_44b13... : PS6, Line 91: "192.168.123.50"
idea: can probably be calculated from `imsi_suffix`?
tbh I'm not even using it for now, and may be removed at some later point Not relevant to the steps I'm doing now, and I'm not really changing it in this commit.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/18206188_a1156... : PS6, Line 310: abba
I hear "ABBA - Dancing Queen" in my head when reading this :D […]
Indeed. That's supposed to be always 0x00000 in current release, so not really interesting.
File library/NG_CryptoFunctions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/86d02e99_c0ba9... : PS6, Line 175: if (nus.role == NG_NAS_ROLE_UE) { : return true; : } else { : return false; : }
`return nus. […]
I just kept it the same as in LTE_CryptoFunctions.ttcn.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/235c02e3_80aef... : PS6, Line 264: make compiler happy about not returning
does `mtc.stop` really make compiler happy? […]
Yes, but afaik ttcn3 doesn't have a way to tell the compiler that a function is not expected to ever return. Hence, the compiler only sees the flow returning from f_shutdown() and nothing being returned.