3 Jan
2023
3 Jan
'23
9:50 a.m.
Attention is currently required from: neels, fixeria, pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )
Change subject: vty: Add check against sensible default value for Ny1
......................................................................
Patch Set 17:
(5 comments)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/f81a51ca_b1681b2e
PS9, Line 1744: unsigned long ny1_recommended = (T3124 + GSM_NY1_REQ_DELTA)/T3105 + 1;
I'm only saying this as a suggestion, in case you
are aiming for a clean ceil() instead of a "custom […]
ah thanks :) I don't
want the ceiling, the ceiling can possibly be too small in this case.
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/6005c7aa_79c3f29b
PS14, Line 1738: unsigned long T3105 = osmo_tdef_get(bts->network->T_defs, 3105,
OSMO_TDEF_MS, -1);
vars are still not declared at the top
Done
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/5cdebd2d_07d1f1a0
PS16, Line 537: }
(braces are still here)
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/00648c1c_a074f648
PS16, Line 1725: .
(stray dot? "iff" isn't an abbreviation
in the usual sense)
it's in the dictionaries (if and only if) and I remember
even seeing it somewhere in a rather big open source project, but I can write it out.
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/aa69f5fd_3af6d6de
PS16, Line 95: (void)
the "(void)" is still here
sorry,
forgot to 'git add' and amend the commit
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089
Gerrit-Change-Number: 30602
Gerrit-PatchSet: 17
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Jan 2023 09:50:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment