Attention is currently required from: neels, fixeria, pespin.
5 comments:
File src/osmo-bsc/bts.c:
Patch Set #9, Line 1744: unsigned long ny1_recommended = (T3124 + GSM_NY1_REQ_DELTA)/T3105 + 1;
I'm only saying this as a suggestion, in case you are aiming for a clean ceil() instead of a "custom […]
ah thanks :) I don't want the ceiling, the ceiling can possibly be too small in this case.
File src/osmo-bsc/bts.c:
Patch Set #14, Line 1738: unsigned long T3105 = osmo_tdef_get(bts->network->T_defs, 3105, OSMO_TDEF_MS, -1);
vars are still not declared at the top
Done
File src/osmo-bsc/bts.c:
(braces are still here)
Done
(stray dot? "iff" isn't an abbreviation in the usual sense)
it's in the dictionaries (if and only if) and I remember even seeing it somewhere in a rather big open source project, but I can write it out.
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:
Patch Set #16, Line 95: (void)
the "(void)" is still here
sorry, forgot to 'git add' and amend the commit
To view, visit change 30602. To unsubscribe, or for help writing mail filters, visit settings.