Attention is currently required from: daniel, laforge.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-pcap/+/39287?usp=email )
Change subject: server: Support storing of pcapng format
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcap/+/39287/comment/42739e69_1946850e?us… :
PS5, Line 13: This requires, during LINK_HDR when file header is received, discering
discering? do you mean distinguishing?
I meant
discerning, will fix
https://dictionary.cambridge.org/dictionary/english/discern
File src/osmo_server_network.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39287/comment/c9b1deeb_a8c7f19c?us… :
PS5, Line 352: BLOCK_TYPE_SHB
why LOGL_DEBUG here vs LOGL_ERROR above for the other
implausible things?
This is wrong, I'll fix, thanks.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39287?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I275d28ab418a1514fa9c5c7c20f3d831cc6af8bb
Gerrit-Change-Number: 39287
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Jan 2025 19:22:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>