[M] Change in libosmo-abis[master]: RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads

Attention is currently required from: falconia. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/37153?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads ...................................................................... RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads TW-TS-001 is an enhanced RTP transport format for FR and EFR codecs that replicates the functionality and semantics of GSM 08.60 TRAU-UL frames. Given that libosmotrau functions support converting from RTP to either TRAU-UL or TRAU-DL, the option of TW-TS-001 fits in naturally. It needs to be noted, however, that the fully correct path in OsmoMGW from RTP input to E1 output will need to include one more critical step _before_ the call to osmo_rtp2trau(): it will be a stateful preening engine that implements the rules of TS 28.062 section C.3.2.1.1, a codec-dependent stateful transform that can be fairly complex. The necessary engines will most likely be implemented in Themyscira codec libraries, and OsmoMGW will need to be outfitted with an _optional_ dependency on those libs. The "native" support for TW-TS-001 input in osmo_rtp2trau() for TRAU-DL (as opposed to TRAU-UL) output is a fallback in the case of OsmoMGW built without any Themyscira codec libraries. Related: OS#6448 Change-Id: I3b2a33c1fcc5a7dafe06736dce5fa5b7b1138e54 --- M src/trau/trau_rtp_conv.c 1 file changed, 77 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/53/37153/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b2a33c1fcc5a7dafe06736dce5fa5b7b1138e54 Gerrit-Change-Number: 37153 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newpatchset