Change in osmo-ci[master]: jobs/gerrit-verifications: add approvals comment

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29687 ) Change subject: jobs/gerrit-verifications: add approvals comment ...................................................................... jobs/gerrit-verifications: add approvals comment Related: OS#2385 Change-Id: I4dfc0f84ffe584523bbff4c41295968a07ba097d --- M jobs/gerrit-verifications.yml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 0e64ff3..8331096 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -17,6 +17,11 @@ # By default the matrix results in only one job, however for some projects we # use the matrix to build for multiple CPU architectures (x86_64, arm) or use # it to build multiple configurations of the same project (see osmo-bts). +# +# NOTE: after updating the job with Jenkins Job Builder as usual, check if a +# new pipeline script was generated and approve it here: +# https://jenkins.osmocom.org/jenkins/scriptApproval/ +# This happens when changing the pipeline script, when adding new projects etc. - project: name: gerrit @@ -364,6 +369,11 @@ name: PIPELINE_BINPKGS description: Enable the binpkgs job (build deb/rpm packages) default: '{obj:pipeline_binpkgs}' + # NOTE: jenkins pipelines don't run unless the dsl-script was approved. + # Sadly this doesn't happen automatically when updating the job with + # Jenkins Job Builder. So if you change the pipeline script, update the job + # as usually with JJB and then approve the scripts here: + # https://jenkins.osmocom.org/jenkins/scriptApproval/ dsl: | pipeline {{ agent {{ label "osmocom-gerrit" }} -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4dfc0f84ffe584523bbff4c41295968a07ba097d Gerrit-Change-Number: 29687 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged