Attention is currently required from: dexter, fixeria, osmith.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/36974?usp=email )
Change subject: add contrib/es9p_client: Perform ES9+ client functions like LPA+eUICC
......................................................................
Patch Set 5:
(6 comments)
File contrib/es9p_client.py:
https://gerrit.osmocom.org/c/pysim/+/36974/comment/a8854d4c_dbd9c038
PS4, Line 40: manuall
manually
Done
https://gerrit.osmocom.org/c/pysim/+/36974/comment/2106af90_bd1f1629
PS4, Line 46:
`parser. […]
Done
https://gerrit.osmocom.org/c/pysim/+/36974/comment/0c372c59_76541d2a
PS4, Line 122: # TODO: verify server certificate against CI
maybe print a note here, that these don't get
verified? same at "# TODO: verify signature", "# TODO: […]
Done
https://gerrit.osmocom.org/c/pysim/+/36974/comment/8898cca8_db5f4d7d
PS4, Line 138: 'sasAcreditationNumber': 'SYSMOCOM-TEST-1',
should this be hardcoded here?
Done
https://gerrit.osmocom.org/c/pysim/+/36974/comment/c7fb4dd8_191aed9d
PS4, Line 236: #print(opts)
debug leftover?
Done
File pySim/esim/es8p.py:
https://gerrit.osmocom.org/c/pysim/+/36974/comment/0b3d97f8_b9daeb04
PS4, Line 233: sequenceOf88
sequenceOf86?
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/36974?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idf8881e82f9835f5221c58b78ced9937cf5fb520
Gerrit-Change-Number: 36974
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 09 Jun 2024 10:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment