Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/35332?usp=email )
Change subject: osmo_stream_srv_link_ofd_cb(): fix wrong socket size passed to accept()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This is wrong.
Could you elaborate more please?
We're passing a pointer to `osa.u.sa` (`struct sockaddr`) but sizeof `osa.u.sas`
(`struct sockaddr_storage`) to `accept()`. Isn't this wrong?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/35332?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie280c255fb2ba790b448e283439c42b766427352
Gerrit-Change-Number: 35332
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Dec 2023 15:29:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment