Attention is currently required from: fixeria, pespin, msuraev, dexter.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 )
Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ......................................................................
Patch Set 8:
(1 comment)
File include/osmocom/gsm/bts_features.h:
https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/7df236ee_597dcb40 PS7, Line 39: _TX
I'm confused: if it's easy to convert between the formats than it can be BTS' runtime config option. […]
Max, you still write "than" instead of "then" =)
For example, a sysmobts emits RTP directly from the DSP in one specific format, i.e. the RTP does not traverse osmo code. AFAIU the on-the-fly conversion can happen only in osmo-mgw, and the BSC has to know which RTP format the BTS expects, in order to instruct the MGW (not sure which MGCP item indicates the format, hope i am understanding correctly). It could be an osmo-bsc.cfg option per 'bts', but if the BTS indicates the format in BTS_FEAT, that is implicit and magically always correct.
If this is correct, I'm with fixeria. Let the BTS_FEAT say which RTP format the PHY emits and expects to receive, so drop the "TX" from the name.
If we are misunderstanding something, plz explain?