[S] Change in libosmocore[master]: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)

Attention is currently required from: fixeria, pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 ) Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ...................................................................... Patch Set 8: (1 comment) File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/7df236ee_597dcb40 PS7, Line 39: _TX Max, you still write "than" instead of "then" =) For example, a sysmobts emits RTP directly from the DSP in one specific format, i.e. the RTP does not traverse osmo code. AFAIU the on-the-fly conversion can happen only in osmo-mgw, and the BSC has to know which RTP format the BTS expects, in order to instruct the MGW (not sure which MGCP item indicates the format, hope i am understanding correctly). It could be an osmo-bsc.cfg option per 'bts', but if the BTS indicates the format in BTS_FEAT, that is implicit and magically always correct. If this is correct, I'm with fixeria. Let the BTS_FEAT say which RTP format the PHY emits and expects to receive, so drop the "TX" from the name. If we are misunderstanding something, plz explain? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 Gerrit-Change-Number: 31415 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Feb 2023 22:31:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment