Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816 )
Change subject: add ps_rab_ass FSM to map GTP via UPF ......................................................................
Patch Set 3:
(8 comments)
Patchset:
PS3: trying to get a final +1 by marking things as "Done"
File include/osmocom/hnbgw/context_map.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/bd1b18d7_276d17db PS1, Line 56: * and each Response gets one ps_rab_ass FSM. Each such message can contain any number and any combination of
one each. […]
Done
File include/osmocom/hnbgw/hnbgw.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/7520ad2e_dac3fa2f PS2, Line 193: /* Return true when the user configured GTP mapping to be enabled, by configuring a PFCP link to a UPF.
If a current setup without GTP-U proxy in SGSN (or HNBGW) is broken, then I think there is an unrela […]
Done
File include/osmocom/hnbgw/hnbgw.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/0de9ab4b_94068899 PS1, Line 193: static inline bool hnb_gw_is_gtp_mapping_enabled(const struct hnb_gw *gw)
"mapping" == "proxying" ... […]
Done
File src/osmo-hnbgw/hnbgw.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/35bf498e_c1dbca47 PS1, Line 230: LOGP(DHNBAP, LOGL_INFO, "deallocating UE context: id 0x%x, imsi %s, tmsi 0x%x\n",
sorry i was distracted by a visitor and lost track
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/838f8bf7_96354c4b PS1, Line 354: LOGP(DMAIN, LOGL_INFO, "Deallocating hnb_context\n");
Same, not resolved.
Done
File src/osmo-hnbgw/ps_rab_fsm.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/c1f9949e_76e51533 PS1, Line 786: .name = "PS_RAB_ST_WAIT_PFCP_DEL_RESP",
WAIT_PFCP_DEL_RESP
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/546ee980_77b364f2 PS1, Line 797: .name = "PS_RAB_ST_WAIT_USE_COUNT",
Not resolved.
Done