Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40019?usp=email )
Change subject: sctp_{client,server}: set sndbuf/recbuf explicitly
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I'm wondering why we use 64k if the kernel default (at least on my system) would be > 200k. Ideally I'd suggest to use something that's close to the kernel default.
One could even read the default from /proc - but I'd think that would be too much effort.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40019?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I66f4a0f6a2441a3c8a4dbd266da8e44a3860b993
Gerrit-Change-Number: 40019
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 14 Apr 2025 10:38:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes