Attention is currently required from: fixeria, laforge, neels, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email )
Change subject: Introduce per-BTS timers, RLC timer commands ......................................................................
Patch Set 18:
(4 comments)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/53580373_9da62382 PS3, Line 1896: static int parse_timer_arg_fmt(struct vty *vty, const char *timer_str, int *tid)
I understand your motivation, this is indeed a problem. […]
functionality has been moved to libosmocore via https://gerrit.osmocom.org/c/libosmocore/+/35355/9
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/3421d774_7ed97e36 PS3, Line 2068:
alright, then I'll be working on a libosmocore patch for that then. […]
https://gerrit.osmocom.org/c/libosmocore/+/35355/9
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/1959fe8a_d26a2edd PS12, Line 39: osmocom/bsc/bts.h
this header is already included below...
Done
File tests/nanobts_omlattr/nanobts_omlattr_test.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/84cfe61b_286e6ebc PS12, Line 138: 3142
Why do these new timers need to be in `gsm_network_T_defs[]`? […]
Done