[L] Change in osmo-ttcn3-hacks[master]: library/PFCP_Emulation: a better PDU routing concept

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email ) Change subject: library/PFCP_Emulation: a better PDU routing concept ...................................................................... Patch Set 2: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207/comment/9cb88e3d_ba17… : PS2, Line 1967: f_PFCPEM_subscribe_seid(c_SEID0); Not really convinced about saving lines, as TITAN fortunately does not impose the limits on that ;) But I see your point about catching messages that are not normally expected and ACKnowledge that. In this specific case the problem can be solved a lot simpler, simply by swapping these two functions, i.e. calling `f_PFCPEM_subscribe_seid()` before `f_PFCPEM_unsubscribe_bcast()`. This way we have no gap and keep the subscription API simple. I'll do this. An alternative solution would be adding an option to the PFCPEM component, that would make it declare a failure if an incoming PDU was not delivered to any `ConnHdlr` and has been dropped. This is a more generic approach, IMO. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I25802471519fa297ad4cb2b056adaa6748b00af2 Gerrit-Change-Number: 38207 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 14:53:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>