Attention is currently required from: fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23918 )
Change subject: pcu_sock: comment out {dl,ul}_tbf_ext related warnings ......................................................................
Patch Set 4:
(1 comment)
File src/common/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bts/+/23918/comment/98025ad0_1a92e628 PS4, Line 317: /* FIXME: isn't dl_tbf_ext wrong?: * 10 and no ntohs */ I just stumbled across this. Without looking much further into it: The RHS expression appears in `src/common/oml.c` (I suppose that's where the bts reads data received from the bsc). There we have `ntohs` and `* 10`.
So if one can assume that's the only expression setting the RHS, these comments can be removed.