18 Jan
2024
18 Jan
'24
10:04 a.m.
Attention is currently required from: dexter, jolly, tnt.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/35563?usp=email )
Change subject: Add support for sending and receiving Sa bits, as well as some line
signals
......................................................................
Patch Set 4:
(1 comment)
File src/e1_input.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/b4d2ed7d_7d301c31
PS4, Line 1124: { S_L_INP_LINE_LOF, "LINE-LOF" },
: { S_L_INP_LINE_NOLOF, "LINE-NOLOF" },
do we really want to introduce additional signals here? As we can see from the existign
list of signals, other hardware typically reports LOS (loss of signal). The icE1usb
can't really do that reliably, so that's a hardware constraint. By adding a new
signal here you basically require each and every application program to also understand
about that new signal.
If we were to report LOF from the driver as LOS to the application, we would be
technically incorrect, but we could assume that the applications likely already know to
deal with LOS so they don't need codec changes.
What do others think? @pmaier@sysmocom.de @tnt@246tNt.com ?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35563?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ie7643693c2daac99f5747591decd60e982b8052a
Gerrit-Change-Number: 35563
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 09:04:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment