Attention is currently required from: neels, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/32218
)
Change subject: mgcp_codec: fix codec decision
......................................................................
Patch Set 11:
(2 comments)
File src/libosmo-mgcp/mgcp_codec.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/71c22f40_fb53a4a9
PS8, Line 401: * a tentative decision is made.
1) ack for dexter. […]
3) The follow up patch
makes this more also more precise. When no no codec is chosen for the destination, then
then mgcp_patch_pt() would fail and the packet would be tossed (follow up patch).
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/fde237f0_67e01d94
PS8, Line 511: rtp_hdr->payload_type = (uint8_t)
conn_dst->end.codec->payload_type;
ACK, AFAIU the PayloadType is assigned to a
connection, not to an endpoint.
Yes that is correct. (The PayloadType is assigned to
a codec and that codec is assigned to a conn)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/32218
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6c3291f825488e5d8ce136aeb18450156794aeb5
Gerrit-Change-Number: 32218
Gerrit-PatchSet: 11
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 02 May 2023 14:38:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment