12 May
2023
12 May
'23
6:46 p.m.
Attention is currently required from: laforge, dexter.
falconia has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32685 )
Change subject: codec: replace GSM-FR ECU with new implementation
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I think review of this patch is slightly more
difficult than it should be due to mixing a file rename with introducing new code. Maybe
first have a commit doing the rename (purely cosmetic, non-functional) and then a commit
that adds the new implementation?
Will do!
Also, I'm not sure if we actually still need to
support the direct API that doesn't go through osmo_ecu_ops_fr.
I thought libosmocore policy was to never remove any once-public APIs, only mark them as
deprecated - or is it not the case? But in the specific case of the old FR-specific ECU
API with publicly exposed state struct, gapk still uses it, and even digs inside struct
osmo_ecu_fr_state.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32685
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0200e423ca6165c1313ec9a4effc3f3047f5f032
Gerrit-Change-Number: 32685
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 12 May 2023 16:46:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment