Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email )
Change subject: ASCI: Add System Information 10 support
......................................................................
Patch Set 1:
(8 comments)
File src/osmo-bsc/system_information.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/7fbe1416_422ea8dc
PS1, Line 1422: struct gsm48_system_information_type_10 *si10 = (struct
gsm48_system_information_type_10*)data;
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/1018d1fc_937af272
PS1, Line 1433: .data_len = len - sizeof(*si10),
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/ed90faab_503ef7a3
PS1, Line 1433: .data_len = len - sizeof(*si10),
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/a7d9392d_9cc2ef23
PS1, Line 1434: .data = si10->rest_octets,
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/ec327412_c7944527
PS1, Line 1434: .data = si10->rest_octets,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/5dba1358_7a767b41
PS1, Line 1435: };
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/b5286d70_b5d00035
PS1, Line 1435: };
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):
https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/b03672ea_d1d12624
PS1, Line 1441: /* If we have gernerated SI5 with seperate SI5 list, the used frequency
indexes refer to it. */
'seperate' may be misspelled - perhaps 'separate'?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3
Gerrit-Change-Number: 34626
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 03 Oct 2023 20:06:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment