View Change

8 comments:

• File src/osmo-bsc/system_information.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):

    Patch Set #1, Line 1422: struct gsm48_system_information_type_10 *si10 = (struct gsm48_system_information_type_10*)data;

    "(foo*)" should be "(foo *)"

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):

    Patch Set #1, Line 1433: .data_len = len - sizeof(*si10),

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):

    Patch Set #1, Line 1433: .data_len = len - sizeof(*si10),

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):

    Patch Set #1, Line 1434: .data = si10->rest_octets,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):

    Patch Set #1, Line 1434: .data = si10->rest_octets,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):

    Patch Set #1, Line 1435: };

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):

    Patch Set #1, Line 1435: };

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11614):

    Patch Set #1, Line 1441: /* If we have gernerated SI5 with seperate SI5 list, the used frequency indexes refer to it. */

    'seperate' may be misspelled - perhaps 'separate'?

To view, visit change 34626. To unsubscribe, or for help writing mail filters, visit settings.