Change in pysim[master]: Improve IST/UST check documentation (for the user manual)

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27182 ) Change subject: Improve IST/UST check documentation (for the user manual) ...................................................................... Improve IST/UST check documentation (for the user manual) Change-Id: I18093d795721f2e729eff858c8922edde9e84451 --- M pySim/ts_31_102.py M pySim/ts_31_103.py 2 files changed, 15 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 7d0eb28..3995dfa 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -644,7 +644,12 @@ self._cmd.card.update_ust(int(arg), 0) def do_ust_service_check(self, arg): - """Check consistency between services of this file and files present/activated""" + """Check consistency between services of this file and files present/activated. + + Many services determine if one or multiple files shall be present/activated or if they shall be + absent/deactivated. This performs a consistency check to ensure that no services are activated + for files that are not - and vice-versa, no files are activated for services that are not. Error + messages are printed for every inconsistency found.""" selected_file = self._cmd.rs.selected_file num_problems = selected_file.ust_service_check(self._cmd) # obtain list of currently active services @@ -802,13 +807,6 @@ """Deactivate a service within EF.UST""" self._cmd.card.update_est(int(arg), 0) - def do_est_service_check(self, arg): - """Check consistency between services of this file and files present/activated""" - # obtain list of currently active services - (service_data, sw) = self._cmd.rs.read_binary_dec() - active_services = service_data.keys() - - # TS 31.102 Section 4.2.48 class EF_ACL(TransparentEF): def __init__(self, fid='6f57', sfid=None, name='EF.ACL', size={32, None}, diff --git a/pySim/ts_31_103.py b/pySim/ts_31_103.py index f04f480..66124a8 100644 --- a/pySim/ts_31_103.py +++ b/pySim/ts_31_103.py @@ -125,9 +125,16 @@ self._cmd.card.update_ist(int(arg), 0) def do_ist_service_check(self, arg): - """Check consistency between services of this file and files present/activated""" + """Check consistency between services of this file and files present/activated. + + Many services determine if one or multiple files shall be present/activated or if they shall be + absent/deactivated. This performs a consistency check to ensure that no services are activated + for files that are not - and vice-versa, no files are activated for services that are not. Error + messages are printed for every inconsistency found.""" selected_file = self._cmd.rs.selected_file - selected_file.ust_service_check(self._cmd) + num_problems = selected_file.ust_service_check(self._cmd) + self._cmd.poutput("===> %u service / file inconsistencies detected" % num_problems) + # TS 31.103 Section 4.2.8 class EF_PCSCF(LinFixedEF): 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I18093d795721f2e729eff858c8922edde9e84451 Gerrit-Change-Number: 27182 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged