Attention is currently required from: fixeria, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28997 )
Change subject: Add osmo_sock_get_name_multiaddr_buf() ......................................................................
Patch Set 17:
(5 comments)
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/917c5219_90712540 PS17, Line 244: OSMO_STRBUF_PRINTF(*sb, "%s%s", oss->ip, after); same as in https://gerrit.osmocom.org/c/libosmocore/+/28993/13/src/core/socket.c#244
...is this code dup? i'm confused
https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/71668273_dd1f67a5 PS17, Line 252: return -ENOSPC; do not size check, for reasons see https://gerrit.osmocom.org/c/libosmocore/+/28993 comments
https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/8143a086_ef7e7fc3 PS17, Line 902: static int sctp_multiaddr_print_ctx_helper(struct osmo_strbuf *sb, int fd, bool local) please let's not introduce string functions that take osmo_strbuf as arguments. (I reasoned earlier today on another patch of yours)
https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/886e3e11_5cdf59e2 PS17, Line 924: rc = multiaddr_strbuf(sb, NULL, 0, &addrs, addr_count); here use
OSMO_STRBUF_APPEND(sb, multiaddr_buf, ...args...)
(if multiaddr_buf() is the correct name for the (char *buf,size_t len) one, i don't recall now)
File tests/socket/socket_sctp_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/8d089043_5ef8bac8 PS17, Line 141: printf("Bound on %s [%d]\n", buf, rc); the rc printed is returned by the string composition, the printf looks like it's about a socket bind. maybe OSMO_ASSERT(rc < sizeof(buf))?