Attention is currently required from: daniel, fixeria, pespin.
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259?usp=email )
Change subject: Translate GSUP Auth Info Answer error Cause in Diamater AIA
......................................................................
Patch Set 2:
(9 comments)
File src/server_cb.erl:
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/2496ee9c_…
PS1, Line 185: gsup_cause2dia(?GMM_CAUSE_ILLEGAL_MS) -> {[],
[?EXP_RES(?DIAMETER_ERROR_USER_UNKNOWN)]};
I may actually want to return a Result-Code in some of
this instead, I need to check what do we have […]
Done
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/e250c90e_…
PS1, Line 187: DIAMETER_ERROR_RAT_NOT_ALLOWED
DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION
Done
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/10339261_…
PS1, Line 189: gsup_cause2dia(?GMM_CAUSE_LA_NOTALLOWED) -> {[],
[?EXP_RES(?DIAMETER_ERROR_RAT_NOT_ALLOWED)]};
Maybe DIAMETER_AUTHORIZATION_REJECTED would be better.
Done
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/256f4ee2_…
PS1, Line 191: DIAMETER_ERROR_UNKOWN_SERVING_NODE
DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION
Done
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/1549bff0_…
PS1, Line 192: DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE
29.272 rel 17: Annex A and Annex B can be used to
translate those. […]
Done
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/5b71fda1_…
PS1, Line 193: gsup_cause2dia(?GMM_CAUSE_CONGESTION) -> {[],
[?EXP_RES(?DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE)]};
I would send unable to comply here, even it is not
defined.
Done
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/a1c0f9dd_…
PS1, Line 194: GMM_CAUSE_GSM_AUTH_UNACCEPT
I would remove this. We should never get this error
and we don't use it on the hlr so far.
Done
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/cb45648b_…
PS1, Line 195: DIAMETER_ERROR_UNKOWN_SERVING_NODE
DIAMETER_MISSING_AVP
Done
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/75dedf38_…
PS1, Line 196: DIAMETER_ERROR_UNKOWN_SERVING_NODE
DIAMETER_UNABLE_TO_COMPLY
Done
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2
Gerrit-Change-Number: 34259
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 02 Sep 2023 15:52:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment