Attention is currently required from: daniel, fixeria, pespin.

View Change

9 comments:

• File src/server_cb.erl:

  • Patch Set #1, Line 185: gsup_cause2dia(?GMM_CAUSE_ILLEGAL_MS) -> {[], [?EXP_RES(?DIAMETER_ERROR_USER_UNKNOWN)]};

    I may actually want to return a Result-Code in some of this instead, I need to check what do we have […]

    Done

  • Patch Set #1, Line 187: DIAMETER_ERROR_RAT_NOT_ALLOWED

    DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION

    Done

  • Patch Set #1, Line 189: gsup_cause2dia(?GMM_CAUSE_LA_NOTALLOWED) -> {[], [?EXP_RES(?DIAMETER_ERROR_RAT_NOT_ALLOWED)]};

    Maybe DIAMETER_AUTHORIZATION_REJECTED would be better.

    Done

  • Patch Set #1, Line 191: DIAMETER_ERROR_UNKOWN_SERVING_NODE

    DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION

    Done

  • Patch Set #1, Line 192: DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE

    29.272 rel 17: Annex A and Annex B can be used to translate those. […]

    Done

  • Patch Set #1, Line 193: gsup_cause2dia(?GMM_CAUSE_CONGESTION) -> {[], [?EXP_RES(?DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE)]};

    I would send unable to comply here, even it is not defined.

    Done

  • Patch Set #1, Line 194: GMM_CAUSE_GSM_AUTH_UNACCEPT

    I would remove this. We should never get this error and we don't use it on the hlr so far.

    Done

  • Patch Set #1, Line 195: DIAMETER_ERROR_UNKOWN_SERVING_NODE

    DIAMETER_MISSING_AVP

    Done

  • Patch Set #1, Line 196: DIAMETER_ERROR_UNKOWN_SERVING_NODE

    DIAMETER_UNABLE_TO_COMPLY

    Done

To view, visit change 34259. To unsubscribe, or for help writing mail filters, visit settings.