Change in osmocom-bb[master]: layer23: fix integer overflow in l1ctl_tx_data_req()

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30962 ) Change subject: layer23: fix integer overflow in l1ctl_tx_data_req() ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/common/l1ctl.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30962/comment/25802b3f_8aed4f39 PS1, Line 397: chan_ts, gsmtap_chan_type, chan_ss, 0, 127, 0, i'm wondering why the fix is not 127, the largest int8_t. I can't tell from the api doc of the argument 'snr'. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I23e9ea5ad59099c24db60057c8e7da1e6a0d2293 Gerrit-Change-Number: 30962 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Jan 2023 22:08:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment