Attention is currently required from: pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 )
Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on
socket files
......................................................................
Patch Set 5:
(1 comment)
File scripts/osmotestconfig.py:
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980/comment/844c4…
PS5, Line 80: ign = shutil.ignore_patterns('*.cfg',
'*tmp_dummy_sock')
So who is creating this tmp_dummy_sock? I don't
find any other reference to it in osmo-python-tests.
The files are created by the
`ctrl_test_runner.py` scripts of several projects through binaries that support the `-r`
option for creating command listener sockets.
```
$ ag tmp_dummy_sock
osmo-bsc-nat/tests/ctrl_test_runner.py
150: os.unlink("tmp_dummy_sock")
153: return ["./src/osmo-bsc-nat/osmo-bsc-nat", "-r",
"tmp_dummy_sock", "-c",
osmo-hnbgw/tests/ctrl_test_runner.py
150: os.unlink("tmp_dummy_sock")
153: return ["./src/osmo-hnbgw/osmo-hnbgw", "-r",
"tmp_dummy_sock", "-c",
docker-playground/osmo-bsc-master/osmo-bsc/tests/ctrl_test_runner.py
150: os.unlink("tmp_dummy_sock")
153: return ["./src/osmo-bsc/osmo-bsc", "-r",
"tmp_dummy_sock", "-c",
573: os.unlink("tmp_dummy_sock")
576: return ["./src/osmo-bsc/osmo-bsc", "-r",
"tmp_dummy_sock", "-c",
610: os.unlink("tmp_dummy_sock")
613: return ["./src/osmo-bsc/osmo-bsc", "-r",
"tmp_dummy_sock", "-c",
osmo-bsc/tests/ctrl_test_runner.py
150: os.unlink("tmp_dummy_sock")
153: return ["./src/osmo-bsc/osmo-bsc", "-r",
"tmp_dummy_sock", "-c",
573: os.unlink("tmp_dummy_sock")
576: return ["./src/osmo-bsc/osmo-bsc", "-r",
"tmp_dummy_sock", "-c",
610: os.unlink("tmp_dummy_sock")
613: return ["./src/osmo-bsc/osmo-bsc", "-r",
"tmp_dummy_sock", "-c",
openbsc/openbsc/tests/ctrl_test_runner.py
155: os.unlink("tmp_dummy_sock")
158: return ["./src/osmo-bsc/osmo-bsc-sccplite", "-r",
"tmp_dummy_sock", "-c",
```
--
To view, visit
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664
Gerrit-Change-Number: 30980
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 12 Feb 2023 20:30:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment