Change in libosmo-gprs[master]: llc: Proper separation of public & private APIs, Introduce llc_prim API

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30489 ) Change subject: llc: Proper separation of public & private APIs, Introduce llc_prim API ...................................................................... Patch Set 1: (29 comments) File include/osmocom/gprs/llc/llc_prim.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/1e176c64_28ea483a PS1, Line 282: uint32_t tlli, uint8_t *ll_pdu, size_t ll_pdu_len); adding a line without newline at end of file File include/osmocom/gprs/llc/llc_private.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/3e7f2843_2f2d9d6e PS1, Line 392: #define LOGLLME(llme, level, fmt, args...) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/553552b9_f17bcb46 PS1, Line 395: #define LOGLLE(lle, level, fmt, args...) \ macros should not use a trailing semicolon File src/llc/llc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/02e9f281_6ca59c21 PS1, Line 463: /* Process an incoming XID indication and generate an appropiate response */ 'appropiate' may be misspelled - perhaps 'appropriate'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/bf4f98b3_d44e5375 PS1, Line 545: if (xid_field->type == OSMO_GPRS_LLC_XID_T_L3_PAR && suspect code indent for conditional statements (16, 32) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/96031d22_43048def PS1, Line 571: /* Dispatch XID indications and responses comming from the MS */ 'comming' may be misspelled - perhaps 'coming'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/f6752ab0_f7734fa6 PS1, Line 609: "TLLI=%08x dropping UI, N(U=%d) not in window V(URV(UR:%d).\n", code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/b0d3e4bf_af51c066 PS1, Line 610: lle->llme ? lle->llme->tlli : -1, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/a34d3bcc_ab3b0915 PS1, Line 611: pdu_dec->seq_tx, lle->vu_recv); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/dfd9d63b_4dbc7da1 PS1, Line 646: } adding a line without newline at end of file File src/llc/llc_bssgp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/fdb35cf7_0e0fa592 PS1, Line 215: (uint8_t*)pdu_dec.data, "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/2f3eea8c_a51b74ec PS1, Line 228: (uint8_t*)pdu_dec.data, "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/81b1aab6_11bf8396 PS1, Line 261: } adding a line without newline at end of file File src/llc/llc_grr.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/979810fd_7fe7f188 PS1, Line 69: } adding a line without newline at end of file File src/llc/llc_ll.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/186d1936_3ce678d6 PS1, Line 266: } adding a line without newline at end of file File src/llc/llc_llgmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/6a946b14_b585543d PS1, Line 64: fields[1].type = OSMO_GPRS_LLC_XID_T_IOV_UI, Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/361e23ef_c4ed8d89 PS1, Line 126: if (old_tlli == TLLI_UNASSIGNED && new_tlli == TLLI_UNASSIGNED) { Statements should start on a tabstop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/25cf1036_b88e7624 PS1, Line 288: } adding a line without newline at end of file File src/llc/llc_prim.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/f11c740b_6ae7f1ee PS1, Line 212: } adding a line without newline at end of file File src/llc/misc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/5ca8b83c_9948d198 PS1, Line 21: int g_llc_log_cat[_GPRS_LLC_LOGC_MAX] = { [0 ... _GPRS_LLC_LOGC_MAX - 1 ] = DLGLOBAL }; space prohibited before that close square bracket ']' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/f6fec3c6_0da0821f PS1, Line 27: } adding a line without newline at end of file File tests/llc/llc_prim_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/d340df86_ff4ece70 PS1, Line 106: 0... .... = Protocol Discriminator_bit: OK code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/83f2882f_a1f0ba03 PS1, Line 107: .0.. .... = Command/Response bit: DownLink/UpLink = Response/Command code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/0e4ae15d_1a1662ca PS1, Line 108: .... 0001 = SAPI: GPRS Mobility Management (1) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/dfe0a447_0a5684a0 PS1, Line 110: 110. .... .... .... = UI format: 0x6 code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/ab4da085_944954d7 PS1, Line 111: ...0 0... .... .... = Spare bits: 0x0 code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/24ebef42_0b0a4f28 PS1, Line 112: .... .000 0000 00.. = N(U): 0 code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/d7aa2b2a_66cc48c3 PS1, Line 113: .... .... .... ..0. = E bit: non encrypted frame code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714): https://gerrit.osmocom.org/c/libosmo-gprs/+/30489/comment/43dea7cc_2f25b2b7 PS1, Line 114: .... .... .... ...0 = PM bit: FCS covers only the frame header and first N202 octets of the information field code indent should use tabs where possible -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I588eb576b2703262f4ab9566ec362920d8390cfd Gerrit-Change-Number: 30489 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 06 Dec 2022 18:37:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment