View Change

29 comments:

• File include/osmocom/gprs/llc/llc_prim.h:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 282: uint32_t tlli, uint8_t *ll_pdu, size_t ll_pdu_len);

    adding a line without newline at end of file

• File include/osmocom/gprs/llc/llc_private.h:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 392: #define LOGLLME(llme, level, fmt, args...) \

    macros should not use a trailing semicolon

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 395: #define LOGLLE(lle, level, fmt, args...) \

    macros should not use a trailing semicolon

• File src/llc/llc.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 463: /* Process an incoming XID indication and generate an appropiate response */

    'appropiate' may be misspelled - perhaps 'appropriate'?

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 545: if (xid_field->type == OSMO_GPRS_LLC_XID_T_L3_PAR &&

    suspect code indent for conditional statements (16, 32)

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 571: /* Dispatch XID indications and responses comming from the MS */

    'comming' may be misspelled - perhaps 'coming'?

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 609: "TLLI=%08x dropping UI, N(U=%d) not in window V(URV(UR:%d).\n",

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 610: lle->llme ? lle->llme->tlli : -1,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 611: pdu_dec->seq_tx, lle->vu_recv);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 646: }

    adding a line without newline at end of file

• File src/llc/llc_bssgp.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 215: (uint8_t*)pdu_dec.data,

    "(foo*)" should be "(foo *)"

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 228: (uint8_t*)pdu_dec.data,

    "(foo*)" should be "(foo *)"

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 261: }

    adding a line without newline at end of file

• File src/llc/llc_grr.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 69: }

    adding a line without newline at end of file

• File src/llc/llc_ll.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 266: }

    adding a line without newline at end of file

• File src/llc/llc_llgmm.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 64: fields[1].type = OSMO_GPRS_LLC_XID_T_IOV_UI,

    Possible comma where semicolon could be used

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 126: if (old_tlli == TLLI_UNASSIGNED && new_tlli == TLLI_UNASSIGNED) {

    Statements should start on a tabstop

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 288: }

    adding a line without newline at end of file

• File src/llc/llc_prim.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 212: }

    adding a line without newline at end of file

• File src/llc/misc.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 21: int g_llc_log_cat[_GPRS_LLC_LOGC_MAX] = { [0 ... _GPRS_LLC_LOGC_MAX - 1 ] = DLGLOBAL };

    space prohibited before that close square bracket ']'

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 27: }

    adding a line without newline at end of file

• File tests/llc/llc_prim_test.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 106: 0... .... = Protocol Discriminator_bit: OK

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 107: .0.. .... = Command/Response bit: DownLink/UpLink = Response/Command

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 108: .... 0001 = SAPI: GPRS Mobility Management (1)

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 110: 110. .... .... .... = UI format: 0x6

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 111: ...0 0... .... .... = Spare bits: 0x0

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 112: .... .000 0000 00.. = N(U): 0

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 113: .... .... .... ..0. = E bit: non encrypted frame

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1714):

    Patch Set #1, Line 114: .... .... .... ...0 = PM bit: FCS covers only the frame header and first N202 octets of the information field

    code indent should use tabs where possible

To view, visit change 30489. To unsubscribe, or for help writing mail filters, visit settings.