[M] Change in osmo-ttcn3-hacks[master]: bsc: improve TC_assignment_csd

Attention is currently required from: osmith, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32343 ) Change subject: bsc: improve TC_assignment_csd ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File bsc/MSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32343/comment/cbeb5521_1056… PS1, Line 212: if (ie.ipa the more ttcn3-native way would probably to match against a template and simply leave it to the automatic "template mismatch" logging to allow the user to see what doesn't match. But of course one can also do it like here. It's just that the philosophy of TTCN3 is exactly that you don't have to have 200 if-clauses testing for individual fielsds of every packet. Doesn't make too much difference in this specific case. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id0e0c5631d7a36635e1ef49cf5bf554f0336556b Gerrit-Change-Number: 32343 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Apr 2023 00:18:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment