[L] Change in osmo-msc[master]: ASCI: Add VTY to configure GCR (Group Call Register)

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33512 ) Change subject: ASCI: Add VTY to configure GCR (Group Call Register) ...................................................................... Patch Set 12: (3 comments) File src/libmsc/asci_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/aa36a2b0_914b9692 PS10, Line 38: DEFUN(vgcs_call, vgcs_call_cmd, Done https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/55d175ba_6c2fdb5c PS10, Line 219: "mute-talker", "Mute talker's downlink") if it's only for testing then it probably should be HIDDEN and maybe also not saved in the config file? https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/ce900301_0e7429cc PS10, Line 261: "no cell POINT_CODE [<0-65535>]", NO_STR "Remove BSS/cell from current group\n" PC_ID_STR) as all our libosmo-sigtran code has user-configurable point code format, I think the same point code format should be used here. Otherwise it's inconsistent to the user. The user doesn't know whihc part of the config is parsed by a library or the application. He'd just be presented with s ome config lines that use his specified format, while others require a hard-coded format. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5bd034a62fc8b483f550d29103c2f7587198f590 Gerrit-Change-Number: 33512 Gerrit-PatchSet: 12 Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Comment-Date: Wed, 05 Jul 2023 13:39:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly &lt;andreas(a)eversberg.eu&gt; Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-MessageType: comment