Attention is currently required from: jolly.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33512 )
Change subject: ASCI: Add VTY to configure GCR (Group Call Register) ......................................................................
Patch Set 12:
(3 comments)
File src/libmsc/asci_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/aa36a2b0_914b9692 PS10, Line 38: DEFUN(vgcs_call, vgcs_call_cmd,
This is used to initiate a voice group call from the VTY. […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/55d175ba_6c2fdb5c PS10, Line 219: "mute-talker", "Mute talker's downlink")
This is not a dispatcher function. Unmuting talker is used for testing a call with a single phone. […]
if it's only for testing then it probably should be HIDDEN and maybe also not saved in the config file?
https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/ce900301_0e7429cc PS10, Line 261: "no cell POINT_CODE [<0-65535>]", NO_STR "Remove BSS/cell from current group\n" PC_ID_STR)
It is default 3.8.8 format. I changed the description accordingly.
as all our libosmo-sigtran code has user-configurable point code format, I think the same point code format should be used here. Otherwise it's inconsistent to the user. The user doesn't know whihc part of the config is parsed by a library or the application. He'd just be presented with s ome config lines that use his specified format, while others require a hard-coded format.