Attention is currently required from: jolly.

View Change

3 comments:

• File src/libmsc/asci_vty.c:

  • Patch Set #10, Line 38: DEFUN(vgcs_call, vgcs_call_cmd,

    This is used to initiate a voice group call from the VTY. […]

    Done

  • Patch Set #10, Line 219: "mute-talker", "Mute talker's downlink")

    This is not a dispatcher function. Unmuting talker is used for testing a call with a single phone. […]

    if it's only for testing then it probably should be HIDDEN and maybe also not saved in the config file?

  • Patch Set #10, Line 261: "no cell POINT_CODE [<0-65535>]", NO_STR "Remove BSS/cell from current group\n" PC_ID_STR)

    It is default 3.8.8 format. I changed the description accordingly.

    as all our libosmo-sigtran code has user-configurable point code format, I think the same point code format should be used here. Otherwise it's inconsistent to the user. The user doesn't know whihc part of the config is parsed by a library or the application. He'd just be presented with s ome config lines that use his specified format, while others require a hard-coded format.

To view, visit change 33512. To unsubscribe, or for help writing mail filters, visit settings.