[M] Change in osmo-ttcn3-hacks[master]: msc: split off f_mo_call_establish__handle_assignment_request()

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email ) Change subject: msc: split off f_mo_call_establish__handle_assignment_request() ...................................................................... Patch Set 2: (3 comments) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/f2ba93a0_1daf… PS2, Line 1557: f_mo_call_establish__handle_assignment_request Hmm, I find the double low-dash a bit weird, but guessing you did it intentionally? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/d0db350a_0c78… PS2, Line 1573: not match(ass_req.pdu.bssmap.assignmentRequest.aoIPTransportLayer, tla_ass1 btw, this matching statement can be simplified a bit to: ``` if (not match(ass_req.pdu.bssmap.assignmentRequest.aoIPTransportLayer, (tla_ass1, tla_ass2)) ``` not strictly related to this patch, just an idea https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/75febbd8_3e1d… PS2, Line 1690: valueof(ts_CodecFR Hmm, so now you're explicitly passing `ts_CodecFR`, but the new function may overwrite it to `ts_CodecCSData`. I find this confusing. Passing the right codec template here _conditionally_ would be cleaner, IMO: ``` if (cpars.csd) { f_mo_call_establish__handle_assignment_request(cpars, bssap, valueof(ts_CodecCSData)); } else { f_mo_call_establish__handle_assignment_request(cpars, bssap, valueof(ts_CodecFR)); } ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98c6171a592dfe1573e15136c4ecf4ff234048d7 Gerrit-Change-Number: 35052 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Nov 2023 12:14:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment