Change in libosmo-abis[master]: e1_input: add timeslot type NONE

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31307 ) Change subject: e1_input: add timeslot type NONE ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Please see my comment in e1_input.c File src/e1_input.c: https://gerrit.osmocom.org/c/libosmo-abis/+/31307/comment/899321fe_8a02d574 PS1, Line 451: There is an open question here: At the moment we implicitly expect the API user to take care that this timeslot no longer has any resources attached to it. It seems that the API was created with the expectation that we never change the mode of a timeslot (which is indeed the case so far). I think we should check here (and also in all other e1inp_ts_config_ functions) if there are still resources pending and take care that all of them are freed. Especially the sign and trau mode hold allocated resources, which could leak. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I073cfaba0d5073447842f22665e213135ea3f635 Gerrit-Change-Number: 31307 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 13 Feb 2023 11:20:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment