View Change

2 comments:

• Patchset:

  • Patch Set #1:

    Please see my comment in e1_input.c

• File src/e1_input.c:

  • Patch Set #1, Line 451:

    There is an open question here: At the moment we implicitly expect the API user to take care that this timeslot no longer has any resources attached to it. It seems that the API was created with the expectation that we never change the mode of a timeslot (which is indeed the case so far).

    I think we should check here (and also in all other e1inp_ts_config_ functions) if there are still resources pending and take care that all of them are freed. Especially the sign and trau mode hold allocated resources, which could leak.

To view, visit change 31307. To unsubscribe, or for help writing mail filters, visit settings.