Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30963 )
Change subject: mobile: fix -Wlogical-not-parentheses in gsm48_cc_init()
......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/mobile/gsm48_cc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30963/comment/ebecfb43_bdeafcca
PS1, Line 54: if (cc->mncc_upqueue.next != NULL)
what about:
if (!llist_empty(&cc->mncc_upqueue))
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30963
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic7ffd3aa25339e24a31bae1b7428f1f93e261858
Gerrit-Change-Number: 30963
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Jan 2023 17:10:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment