Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105 )
Change subject: ggsn: Append IMEISV IE to CreatePdpCtxReq ......................................................................
Patch Set 1:
(2 comments)
File ggsn_tests/GGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105/comment/8d174739_b9652... PS1, Line 338: return int2oct(f_rnd_int(18446744073709551616), 8); There is a more elegant way to do this (see Osmocom_Types.f_rnd_imsi()):
return hex2oct(f_rnd_hexstring(16, 10));
File library/GTP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105/comment/0a914183_227b0... PS1, Line 129: Usually no tab here, so function body is visually separated from its declaration.