Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/33094 )
Change subject: libosmogsm: Add support for TUAK authentication algorithm
......................................................................
Patch Set 5:
(3 comments)
File include/osmocom/crypt/auth.h:
https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa72d751_4543c21f
PS5, Line 36: OSMO_AUTH_ALG_TUAK,
update TODO-RELEASE (new symbols).
File src/gsm/auth_tuak.c:
https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/305fe972_3d40eceb
PS5, Line 45: } else
if {} else {}.
Actually, you can drop the else (early return in if).
File tests/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/30e2d4f4_9d4946f8
PS5, Line 401: auth/milenage_test.ok \
this looks wrong?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/33094
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d
Gerrit-Change-Number: 33094
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 30 May 2023 15:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment